Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circular call logic and exception annotations #2028

Merged
merged 8 commits into from
Jun 24, 2020
Merged

Circular call logic and exception annotations #2028

merged 8 commits into from
Jun 24, 2020

Conversation

iamdefinitelyahuman
Copy link
Contributor

@iamdefinitelyahuman iamdefinitelyahuman commented Jun 24, 2020 •
edited by fubuloubu
Loading

Fixes: #1707

What I did

  • allow exceptions to be annotated with multiple nodes
  • add circular call check
  • check for modificaiton of iterated array in for loop, including via function calls
  • misc fixes to interfaces and events

Sooooo close....

How to verify it

Run tests. Read code.

Cute Animal Picture

image

fubuloubu
fubuloubu reviewed Jun 24, 2020
View reviewed changes
vyper/exceptions.py Show resolved Hide resolved
vyper/exceptions.py Show resolved Hide resolved
vyper/signatures/event_signature.py Outdated Show resolved Hide resolved
@fubuloubu
Copy link
Member

This solves #1707 right?

@iamdefinitelyahuman
Copy link
Contributor Author

This solves #1707 right?

Yes :)))

@codecov-commenter
Copy link

Codecov Report

Merging #2028 into next will decrease coverage by 0.00%.
The diff coverage is 89.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #2028      +/-   ##
==========================================
- Coverage   85.09%   85.08%   -0.01%     
==========================================
  Files          83       83              
  Lines        7982     8051      +69     
  Branches     1925     1951      +26     
==========================================
+ Hits         6792     6850      +58     
- Misses        716      721       +5     
- Partials      474      480       +6
Impacted Files Coverage Δ
vyper/signatures/event_signature.py 77.61% <0.00%> (-2.99%) ⬇️
vyper/context/validation/module.py 89.04% <87.17%> (-0.78%) ⬇️
vyper/exceptions.py 97.87% <91.66%> (+2.36%) ⬆️
vyper/context/validation/local.py 91.28% <92.59%> (-0.22%) ⬇️
vyper/context/types/event.py 94.28% <100.00%> (+0.34%) ⬆️
vyper/context/types/function.py 86.40% <100.00%> (+0.22%) ⬆️
vyper/context/types/indexable/sequence.py 84.00% <100.00%> (ø)
vyper/context/types/meta/interface.py 88.31% <100.00%> (+0.64%) ⬆️
vyper/parser/stmt.py 79.46% <100.00%> (ø)
vyper/parser/parser.py 86.81% <0.00%> (-2.20%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07992a6...b295884. Read the comment docs.

@iamdefinitelyahuman iamdefinitelyahuman merged commit ff25e5c into vyperlang:next Jun 24, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the feat-ordering branch June 24, 2020 20:48
@iamdefinitelyahuman iamdefinitelyahuman mentioned this pull request Jun 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamdefinitelyahuman @fubuloubu @codecov-commenter